From 69fc3ca490ee43c429c3a50fe964fa4b344111d5 Mon Sep 17 00:00:00 2001 From: trisua Date: Sun, 22 Jun 2025 15:15:39 -0400 Subject: [PATCH] fix: remove MANAGE_INVITES (overflow) --- crates/app/src/public/html/mod/profile.lisp | 1 - crates/core/src/database/invite_codes.rs | 6 +++--- crates/core/src/model/permissions.rs | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/app/src/public/html/mod/profile.lisp b/crates/app/src/public/html/mod/profile.lisp index b036e23..28ef09d 100644 --- a/crates/app/src/public/html/mod/profile.lisp +++ b/crates/app/src/public/html/mod/profile.lisp @@ -258,7 +258,6 @@ MANAGE_APPS: 1 << 28, MANAGE_JOURNALS: 1 << 29, MANAGE_NOTES: 1 << 30, - MANAGE_INVITES: 1 << 31, }, ], ); diff --git a/crates/core/src/database/invite_codes.rs b/crates/core/src/database/invite_codes.rs index 18e4aec..760b469 100644 --- a/crates/core/src/database/invite_codes.rs +++ b/crates/core/src/database/invite_codes.rs @@ -97,8 +97,8 @@ impl DataManager { .to_string(), )); } - } else if !user.permissions.check(FinePermission::MANAGE_INVITES) { - // check count + } else if !user.permissions.check(FinePermission::MANAGE_USERS) { + // check count since we're also not a moderator with MANAGE_USERS if self.get_invite_codes_by_owner(user.id).await?.len() >= Self::MAXIMUM_SUPPORTER_INVITE_CODES { @@ -134,7 +134,7 @@ impl DataManager { } pub async fn delete_invite_code(&self, id: usize, user: &User) -> Result<()> { - if !user.permissions.check(FinePermission::MANAGE_INVITES) { + if !user.permissions.check(FinePermission::MANAGE_USERS) { return Err(Error::NotAllowed); } diff --git a/crates/core/src/model/permissions.rs b/crates/core/src/model/permissions.rs index 97c0c3f..9cd6dcb 100644 --- a/crates/core/src/model/permissions.rs +++ b/crates/core/src/model/permissions.rs @@ -39,7 +39,6 @@ bitflags! { const MANAGE_APPS = 1 << 28; const MANAGE_JOURNALS = 1 << 29; const MANAGE_NOTES = 1 << 30; - const MANAGE_INVITES = 1 << 31; const _ = !0; }